Skip to content

docs(cache): Add documentation for memcache_customprefix setting#14080

Open
Earl0fPudding wants to merge 11 commits intonextcloud:masterfrom
Earl0fPudding:custom-cache-prefix
Open

docs(cache): Add documentation for memcache_customprefix setting#14080
Earl0fPudding wants to merge 11 commits intonextcloud:masterfrom
Earl0fPudding:custom-cache-prefix

Conversation

@Earl0fPudding
Copy link

@Earl0fPudding Earl0fPudding commented Feb 17, 2026

☑️ Resolves

🖼️ Screenshots

Screenshot from 2026-02-17 18-20-45 Screenshot from 2026-02-17 18-24-27

Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
@Earl0fPudding Earl0fPudding changed the title feat(cache): Add documentation for memcache.customprefix setting docs(cache): Add documentation for memcache.customprefix setting Feb 17, 2026
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
@Earl0fPudding Earl0fPudding changed the title docs(cache): Add documentation for memcache.customprefix setting docs(cache): Add documentation for memcache_customprefix setting Feb 18, 2026
@susnux susnux requested a review from nickvergessen February 27, 2026 20:36
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good. Thanks for the docs update

Earl0fPudding and others added 2 commits March 4, 2026 14:34
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
@kesselb
Copy link
Contributor

kesselb commented Mar 5, 2026

Hey, I think the description might be a bit inaccurate and somewhat unnecessarily alarming. The hashed instance ID, plus server version and app versions, already gives you a pretty unique key. The main reason for this change is, as suggested in the initial issue, to have a stable prefix to define ACLs.

@Earl0fPudding
Copy link
Author

I see what you mean, but in this case it would be 100% unique in the caching system. The ability to create ACLs in Redis is also a huge benefit security-wise when having multiple applications using the same Redis instance. So personally, I think that's quite a big deal and the description should be fine, but I can of course change it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants