docs(cache): Add documentation for memcache_customprefix setting#14080
docs(cache): Add documentation for memcache_customprefix setting#14080Earl0fPudding wants to merge 11 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
admin_manual/configuration_server/config_sample_php_parameters.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
nickvergessen
left a comment
There was a problem hiding this comment.
Otherwise good. Thanks for the docs update
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
|
Hey, I think the description might be a bit inaccurate and somewhat unnecessarily alarming. The hashed instance ID, plus server version and app versions, already gives you a pretty unique key. The main reason for this change is, as suggested in the initial issue, to have a stable prefix to define ACLs. |
|
I see what you mean, but in this case it would be 100% unique in the caching system. The ability to create ACLs in Redis is also a huge benefit security-wise when having multiple applications using the same Redis instance. So personally, I think that's quite a big deal and the description should be fine, but I can of course change it if you want. |
☑️ Resolves
🖼️ Screenshots